Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New possible rules to analyze #568

Open
dbale-altoros opened this issue Mar 19, 2024 · 2 comments
Open

New possible rules to analyze #568

dbale-altoros opened this issue Mar 19, 2024 · 2 comments
Labels

Comments

@dbale-altoros
Copy link
Collaborator

boolean_comparison
Checks if an expression contains a comparison with a boolean literal, which is unnecessary.
(best practices)

division_before_multiplication
Checks for division operations before multiplications, which can result in value truncation.

external_call_in_loop
Checks if any functions contain any loops which perform calls to external functions.
(security)

missing_logs
Checks for publicly-accessible functions that make changes to storage variables without emitting logs.
(security)

storage_read_in_loop_condition
Checks for loops that contain a storage read in their condition, which can increase gas costs for each iteration.
(gas)

@ScreamingHawk
Copy link

unused_return_value

This is already a compiler warning for low level calls and could be extended for all calls.

@dbale-altoros
Copy link
Collaborator Author

@ScreamingHawk thanks for your input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants