Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of V8 Liftoff compiler #323

Open
mpwarres opened this issue Nov 27, 2022 · 0 comments
Open

Allow use of V8 Liftoff compiler #323

mpwarres opened this issue Nov 27, 2022 · 0 comments
Assignees

Comments

@mpwarres
Copy link
Contributor

Currently the V8 integration explicitly disables the Liftoff compiler. AIUI this is to force V8 to only use TurboFan for code generation, so that in uses such as Envoy where there are N separate thread-local VMs, we incur the cost of eager TurboFan code generation only once, prior to cloning each of the thread-local VMs.

However, Liftoff offers significant benefits for use cases requiring quick plugin startup time--in some benchmarks we have seen it consume <5% of the CPU time of TurboFan. For those use cases it would be useful to have the option to enable Liftoff for V8.

@mpwarres mpwarres assigned mpwarres and fengshi0730 and unassigned mpwarres Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants