Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly syntax incompatible with clang's internal assembler #18

Closed
arnetheduck opened this issue Feb 8, 2024 · 1 comment
Closed

Comments

@arnetheduck
Copy link
Contributor

clang hashtree/src/sha256_avx_x8.S

hashtree/src/sha256_avx_x8.S:587:13: error: ambiguous operand size for instruction 'cmp'
        cmp NUM_BLKS, 0
            ^~~~~~~~
hashtree/src/sha256_avx_x8.S:615:6: error: ambiguous operand size for instruction 'cmp'
 cmp NUM_BLKS, 8
     ^~~~~~~~
...

Adding -no-integrated-as works around the problem by passing the file to the system as instead.

clang 17, b12467b

@potuz
Copy link
Collaborator

potuz commented May 25, 2024

I don't think we'll ever switch to clang's internal assembler, so I'm closing this issue as running with the system assembler -no-integrated-as seems to work on all systems supported currently by the library. This was merged in #32 and workflow on linux was added in #34

@potuz potuz closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants