Duplicate Definitions

[astrelsky]

ps2sdk/common/include/gs_gp.h

Lines 166 to 168 in 85bc643

	// For generic enabling or disabling
	#define GS_DISABLE 0x00
	#define GS_ENABLE 0x01

ps2sdk/ee/libgs/include/libgs.h

Lines 62 to 63 in 85bc643

	#define GS_DISABLE 0
	#define GS_ENABLE 1

While their values are the same it still produces a warning.

[rickgaiser]

There's a lot more duplicate things in those two header files. They look like 2 different GS libraries. For instance:

ps2sdk/common/include/gs_gp.h

Line 45 in 8b75799

#define GS_REG_TEX1_1 0x14

ps2sdk/ee/libgs/include/libgs.h

Line 245 in 8b75799

#define gs_g_tex1_1 0x14

The GS_DISABLE/GS_ENABLE is probably the only conflict though. We could add #ifndef GS_DISABLE... etc... around these 2 definitions in both files I guess. But why would code use both libraries at the same time?

[astrelsky]

There's a lot more duplicate things in those two header files. They look like 2 different GS libraries. For instance:

ps2sdk/common/include/gs_gp.h

Line 45 in 8b75799

#define GS_REG_TEX1_1 0x14

ps2sdk/ee/libgs/include/libgs.h

Line 245 in 8b75799

#define gs_g_tex1_1 0x14

The GS_DISABLE/GS_ENABLE is probably the only conflict though. We could add #ifndef GS_DISABLE... etc... around these 2 definitions in both files I guess. But why would code use both libraries at the same time?

I honestly don't know why. However, if they are intended to be separate libraries, shouldn't they be guarded to prevent them from being used at the same time?