Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old files #109

Closed
Koded opened this issue Oct 21, 2015 · 3 comments
Closed

Remove old files #109

Koded opened this issue Oct 21, 2015 · 3 comments

Comments

@Koded
Copy link

Koded commented Oct 21, 2015

As far as I can tell, due to the way Flightplan is using Rsync, old files will not be removed from the server.

I.e., if I deploy some files to a server, then remove some files locally, and re-deploy, the files that have been deleted locally will remain on the server.

This is because of a couple of reasons, firstly that the Rsync flag --delete isn't being used. But more importantly, and fundamentally, even if it was it wouldn't remove them because --from-file is being used, which means Rsync will ignore deleted files.

I'm not sure that Flightplan claims to sync files, just to upload them, so this feels more like an enhancement.

Solving this ticket would help sort this issue out: #71

@Koded Koded changed the title Remove old files. Remove old files Oct 21, 2015
@pstadler
Copy link
Owner

The idea is indeed not to sync. However, I do understand the need of making transport more flexible. 👍

@pstadler
Copy link
Owner

I'm closing this in favor of #71

@Koded
Copy link
Author

Koded commented Oct 21, 2015

Makes sense. Thanks for confirming @pstadler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants