New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deprecation and Warning #1

Open

zipymonkey opened this issue Nov 6, 2024 · 0 comments

Labels

bug

Collaborator

zipymonkey commented Nov 6, 2024

The module throws warnings and deprecation notices when using no Penn State openid_connect clients (i.e. github as an example).

Warning: Undefined array key "upn" in psul_user_auth_openid_connect_userinfo_alter() (line 21 of modules/custom/psul_user_auth/psul_user_auth.module).

Deprecated function: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in psul_user_auth_openid_connect_userinfo_alter() (line 21 of modules/custom/psul_user_auth/psul_user_auth.module).

We should check that the upn parameter exists before using it the preg_match.

zipymonkey added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment