Schedule next_run does not take daylight savings time into account

[m0uka]

Current Behavior

Currently, due to the change to daylight savings time, every schedule that was previously executed yesterday was executed an hour later.
I am guessing it happens because next_run_at is being set when the previous schedule executes, causing the resulting date to not include DST.

Expected Behavior

The schedule should be executed at the same time every time.
Maybe make next_run_at use UTC, so there won't be any problems with DST (make getNextRunDate return UTC, and instead of NOW() use UTC_TIMESTAMP())?

Steps to Reproduce

1. Create a schedule that executes every day at 12:00
2. Wait until daylight savings time starts
3. The day DST starts, the schedule will execute an hour later

Panel Version

1.7.0

Wings Version

1.6.1

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

• I have searched the existing issues before opening this issue.
• I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
• I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

[parkervcp]

This should depend on your system time.

[m0uka]

The system time is correct, now the schedules are running normally, but if the previous schedule ran without DST, then the next would run +1 hour later, after that everything is normal

[DaneEveritt]

Seems more like a bug with the cron library. I don't actually have any particularly special logic that would be the culprit.

panel/app/Models/Schedule.php

Lines 133 to 140 in 14cc98f

	public function getNextRunDate()
	{
	$formatted = sprintf('%s %s %s %s %s', $this->cron_minute, $this->cron_hour, $this->cron_day_of_month, $this->cron_month, $this->cron_day_of_week);
	return CarbonImmutable::createFromTimestamp(
	(new CronExpression($formatted))->getNextRunDate()->getTimestamp()
	);
	}

[m0uka]

Apparently not a bug - mtdowling/cron-expression#116
What about refactoring it to use UTC? I know this is a really minor issue, but it can be annoying and confusing to some people.

[DaneEveritt]

Guessing it might be a bug that was long fixed in https://github.com/dragonmantank/cron-expression which is the actual library we use, in which case it will likely end up fixed in coming weeks as we update dependencies and push out those changes.

[jchambo]

Guessing it might be a bug that was long fixed in https://github.com/dragonmantank/cron-expression which is the actual library we use, in which case it will likely end up fixed in coming weeks as we update dependencies and push out those changes.

Was this ever looked into / resolved? I'm still seeing this myself in Schedules.

You can see these are actually offset by an hour, and have been since Daylight Savings changed on 03/12/2023.