Upgrade from Rails 3.2 to Rails 4.2.8

[sashadev-sky]

References #305 #345

Current system versions:
Rails 3.2
Ruby 2.4.4

[sashadev-sky]

Tagging some relevant people @cesswairimu @Souravirus @jywarren @stefannibrasil @gauravano @alaxalves

[kaustubh-nair]

Rails 4.0 and Ruby 2.4 are not compatible. ( Relevant issue: rails/rails#27670)
You'll run into <class:Numeric>': stack level too deep (SystemStackError) error
The best approach is to directly upgrade to Rails 4.2.8 or higher
Thanks

[sashadev-sky]

@kaunair sorry i meant to tag you in this too!! I'm actually not going to be able to open a PR for this for a week or so, so you can address it if you wanted to get a head start!

Thank you for advising me on that though I will keep that in mind if I do end up opening the PR for it. @alaxalves mentioned he went with 4.2.8 so I'm going to run with that too as per your suggestion. Updating the issue name! Thanks!

[alaxalves]

@sashadev-sky I started some work regarding this a while ago in https://github.com/alaxalves/mapknitter/tree/rails4, as I said here but @jywarren told me to wait for it a little here. Maybe because of GSoC. 🤔

[sashadev-sky]

@alaxalves Yeah just getting the ball rolling. There will still be a lot of work to do for SoC in terms of upgrades even if we get it to Rails 4. But @kaustubh-nair had a proposal for doing the upgrades and he's getting involved here early (thank you!)

[sashadev-sky]

@alaxalves Sorry I just realized you might have a proposal for this too based on a comment you wrote!! I'm not involved in the proposal process at all I just happened to see @kaustubh-nair's at some point so apologies if I created any confusion or left you out in the last comment. Just trying to upgrade Rails sooner and thank you for helping too :)

[grvsachdeva]

I think you all can divide the upgrade tasks and work keeping each other in sync?

[kaustubh-nair]

The upgrade is paused for now. Since we don't have enough test coverage. We'll continue after that

[sashadev-sky]

@kaustubh-nair yeah thats what I think @gauravano was getting at - dividing up the test coverage and other work between us

[sashadev-sky]

+1 @gauravano

[grvsachdeva]

Also, you can get expert help from @Souravirus (expert of big PRs 🙈 ) and he also did this kind of upgrade last year for plots2 - jywarren/plots2#266 and then Rails upgrade in GSoC. And, you know @siaw23 (the Rubyist)

Thanks!

[cesswairimu]

Just noting here, I was trying to build on top of #482 as we had discussed with @kaustubh-nair but was finding it overwhelming because of the different changes in the in between versions. I also found elsewhere that the Rails 4.0 and Ruby 2.4 compatibility was fixed. Trying out if this will work on #578 😑 . This would be better if it works for debugging and making sure we don't miss anything between the versions. Also if it doesn't work will fall back on #482 😥 Thanks all

[jywarren]

Awesome!

…

On Sun, May 5, 2019, 4:26 AM Cess ***@***.***> wrote: Just noting here, I was trying to build on top of #482 <#482> as we had discussed with @kaustubh-nair <https://github.com/kaustubh-nair> but was finding it overwhelming because of the different changes in the in between versions. I also found elsewhere that the Rails 4.0 and Ruby 2.4 compatibility was fixed. Trying out if this will work on #578 <#578>. This would be better if it works for debugging and making sure we don't miss anything between the versions. Also if it doesn't work will fall back to #482 <#482>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#481 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J6K6RUNPCOA4FVYIOTPT2KZFANCNFSM4HDF3MDA> .