-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jasmine tests not running #2967
Comments
@jywarren Have a look at this. |
oh huh... do you think this could somehow be related to Rails 5 and the
gems that help run Jasmine? Does it run locally?
…On Sun, Jul 1, 2018 at 5:50 PM Sourav Sahoo ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Have a look at this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5j3kY_k9bfN_JnQ3V3dub2ixtutks5uCUP_gaJpZM4U-fAJ>
.
|
No, its not related to rails 5. As I have seen the commits before the rails 5.0 upgrade and it was not running even on them. |
hmm, we've had trouble keeping these running. Does it run locally? It seems
like phantomjs executes, but doesn't find the tests?
…On Tue, Jul 3, 2018 at 10:35 AM Sourav Sahoo ***@***.***> wrote:
No, its not related to rails 5. As I have seen the commits before the
rails 5.0 upgrade and it was not running even on them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ2YQ52zcPWMGnCHkTU7Ur80eG6bSks5uC4EYgaJpZM4U-fAJ>
.
|
No not running locally also |
I was using the command as is used in the test |
OK, good to know. Would you mind looking back at when this stopped working so we can pinpoint the commit that caused it? |
Yeah I would search for it. Looks like I have to use binary search for it. 😆 😆 |
yeah, sorry, it's a pain! |
no problem |
Here it occured due to this commit: |
hey, it's not a blame game, just a detective game! 😄 🔍 Is it somehow possible that the use of |
Yeah ok trying this fix and lets see what happens. Thanks for the help!! |
Nopes it didn't worked |
@jywarren now this is interesting, jasmine is finding the specs when run through web browser. Here is the screenshot: |
I got something testdouble/jasmine-rails#220 . I guess since in that PR I used modern ES features that's why the phantomjs is unable to find the jasmine tests and it chokes. So, thats why I guess jasmine tests are not running. I think we must move on to another alternative. What do you think? |
besides jasmine-rails or beyond Jasmine itself? Sure, what options do we
have?
…On Tue, Jul 3, 2018 at 5:38 PM Sourav Sahoo ***@***.***> wrote:
I got something testdouble/jasmine-rails#220
<testdouble/jasmine-rails#220> . I guess since in
that PR I used modern ES features that's why the phantomjs is unable to
find the jasmine tests and it chokes. So, thats why I guess jasmine tests
are not running. I think we must move on to another alternative. What do
you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_ia0bveP0m4GQN7v0JpMmhjFHf9ks5uC-QWgaJpZM4U-fAJ>
.
|
Yeah I will look at it about how to perfectly test javascript in rails |
awesome!
…On Tue, Jul 3, 2018 at 5:46 PM Sourav Sahoo ***@***.***> wrote:
Yeah I will look at it about how to perfectly test javascript in rails
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJxziOXVLTRIdsXONNVWpzWhcsSbSks5uC-YLgaJpZM4U-fAJ>
.
|
I am not getting the perfect tests. Tried karma and teaspoon-jasmine but there are some issues with each of them. |
ok I am currently setting up mocha in rails app. |
Report is:
Running "/home/sourav/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs" "/home/sourav/.rvm/gems/ruby-2.4.1/gems/jasmine-rails-0.14.7/lib/jasmine_rails/../assets/javascripts/jasmine-runner.js" "file:///home/sourav/Documents/gsoc/plots2/tmp/jasmine/runner.html?root=/home/sourav/Documents/gsoc/plots2&spec="
Running: file:///home/sourav/Documents/gsoc/plots2/tmp/jasmine/runner.html?root=/home/sourav/Documents/gsoc/plots2&spec=
Starting...
Finished
0 specs, 0 failures in 0.061s.
ConsoleReporter finished
No specs are running
The text was updated successfully, but these errors were encountered: