Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isUnique() is broken in https://github.com/katlew/Cracking-Coding-Interview/blob/master/chapter_1/isUnique_bit.java #2

Open
millfreedom opened this issue Aug 27, 2019 · 1 comment
Open

isUnique() is broken in https://github.com/katlew/Cracking-Coding-Interview/blob/master/chapter_1/isUnique_bit.java #2

millfreedom opened this issue Aug 27, 2019 · 1 comment

Comments

@millfreedom
Copy link

HERE you have broken isUnique() method

try this, e.g.:
if (!isUnique("[{")) throw new RuntimeException("over-optimisation detected");
@lejaokri
Copy link

isUnique_bit() will only support lower-case ascii characters. should have added it in the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lejaokri @millfreedom