Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Skip cloning loot parameters" patch is useless #85

Open
MrPowerGamerBR opened this issue Oct 23, 2023 · 1 comment
Open

"Skip cloning loot parameters" patch is useless #85

MrPowerGamerBR opened this issue Oct 23, 2023 · 1 comment

Comments

@MrPowerGamerBR
Copy link

MrPowerGamerBR commented Oct 23, 2023

I was looking into Pufferfish's patches, and while I was looking into it, I looked at the https://github.com/pufferfish-gg/Pufferfish/blob/ver/1.20/patches/server/0031-Skip-cloning-loot-parameters.patch patch... and it feels like it is useless and is causing two unnecessary allocations.

If you look at the original patch from Airplane, it makes sense why they made that change: Vanilla used ImmutableMap.copyOf to copy the maps, but on recent versions this is useless since it doesn't do that anymore: https://github.com/TECHNOVE/Airplane/blob/ver/1.17/patches/server/0030-Skip-cloning-loot-parameters.patch

And on another note, the "Reduce entity allocations" allocate a MutableBlockPos for each created entity, but that cachedBlockPos variable is never used! Heck, not even in Airplane that variable seems to be used.

@Potothingi
Copy link

@kev626
Please read the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants