54 MigrationUploadSnapshots that are not complete

[carolyncole]

Expected behavior

There are 54 migration upload snapshots that are marked as not complete. I noticed this phenomenon when I was looking at the migration of #38.

irb(main):004:0> MigrationUploadSnapshot.all.select {|snapshot| ! snapshot.migration_complete?}.count
=> 54

Actual behavior

Even though the migration was complete, the snapshot was not thinking it was complete. It seems the name in the snapshot for the dataspace files is not the same name that is getting output at the end so the files are not getting marked as done.

Impact of this bug

This means that there is never a migration line in the history for the work.

Acceptance criteria

• Create a report of the 54 items in this list and give it to the curator
  • Give it to the Curators to check and see if these are known items

  all_snapshots = MigrationUploadSnapshot.all
  pending_snapshots = all_snapshots.select {|snapshot| ! snapshot.migration_complete?}
  

• For each migration that is verified as a duplicate: Delete the notations that are not completed, and then finalize the migration.

  # These ones are possibly of this case (there are 42)
  more_complete = pending_snapshots.select {|snapshot| snapshot.existing_files.count >= (snapshot.files.count/2)}
  

  • write a script to verify that all started files have a completed counterpart in the MigratioUploadSnapshot file list
  • For the ones that do have all started with matching completed, remove the started and call the finalize the snapshot method

[carolyncole]

Hey team! Please add your planning poker estimate with Zenhub @hectorcorrea @JaymeeH @jrgriffiniii @leefaisonr