Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iDMA legalizer has dependencies from valids to readys on internal signals #6

Open
thommythomaso opened this issue Aug 9, 2022 · 0 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@thommythomaso
Copy link
Collaborator

Some internal signals in the legalizer have their valid signals dependent on ready signals. Ideally, to keep it consistent with the AXI handshaking, this should not be the case.

iDMA/src/idma_legalizer.sv

Lines 374 to 388 in 201ec2e

always_comb begin : proc_legalizer_flow_control
if (opt_tf_q.decouple_rw) begin
r_tf_ena = (r_ready_i & !flush_i) | kill_i;
w_tf_ena = (w_ready_i & !flush_i) | kill_i;
r_valid_o = r_tf_q.valid & r_ready_i & !flush_i;
w_valid_o = w_tf_q.valid & w_ready_i & !flush_i;
end else begin
r_tf_ena = (r_ready_i & w_ready_i & !flush_i) | kill_i;
w_tf_ena = (r_ready_i & w_ready_i & !flush_i) | kill_i;
r_valid_o = r_tf_q.valid & w_ready_i & r_ready_i & !flush_i;
w_valid_o = w_tf_q.valid & r_ready_i & w_ready_i & !flush_i;
end
end

@thommythomaso thommythomaso changed the title iDMA legalizer has dependencies from valids to readys on *internal* signals iDMA legalizer has dependencies from valids to readys on **internal** signals Aug 9, 2022
@thommythomaso thommythomaso changed the title iDMA legalizer has dependencies from valids to readys on **internal** signals iDMA legalizer has dependencies from valids to readys on internal signals Aug 9, 2022
@thommythomaso thommythomaso added the invalid This doesn't seem right label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant