Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oneshots services being called twice #487

Closed

Conversation

newswangerd
Copy link
Contributor

Removes base as a dependency from oneshot services.

closes #474

@newswangerd
Copy link
Contributor Author

@mikedep333 wdyt about this? I found your issue on s6 (just-containers/s6-overlay#476). I'm not an expert, but I think it should be okay to have the one shots not depend on base because it looks to me like the fix-attrs service only affects longrun services, and those don't seem to get launched twice like the oneshots do.

@mikedep333
Copy link
Member

Hi @newswangerd ,

If this works, great.

However, please test my original theory from the bug. Try launching with -e PULP_WORKERS=1. If the oneshots still run, then we can merge. Thank you!

@stale
Copy link

stale bot commented Jun 25, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Jun 25, 2023
@newswangerd newswangerd reopened this Jun 29, 2023
@stale
Copy link

stale bot commented Jun 29, 2023

This pull request is no longer marked for closure.

@stale stale bot removed the stale label Jun 29, 2023
@newswangerd
Copy link
Contributor Author

Hi @newswangerd ,

If this works, great.

However, please test my original theory from the bug. Try launching with -e PULP_WORKERS=1. If the oneshots still run, then we can merge. Thank you!

Did you have time to test this?

@stale
Copy link

stale bot commented Jul 29, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Jul 29, 2023
@stale
Copy link

stale bot commented Aug 29, 2023

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oneshots get called twice
2 participants