Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow boolean settings to accept 'true', 't', 'yes', and 'y' #624

Open
dkliban opened this issue Apr 3, 2024 · 2 comments
Open

Allow boolean settings to accept 'true', 't', 'yes', and 'y' #624

dkliban opened this issue Apr 3, 2024 · 2 comments
Labels

Comments

@dkliban
Copy link
Member

dkliban commented Apr 3, 2024

The boolean settings that control the behavior of the multi process container should accept 'true', 't', 'yes', and 'y' for True.

PULP_HTTPS
PULP_GUNICORN_RELOAD
PULP_OTEL_ENABLED

@mdellweg
Copy link
Member

mdellweg commented Apr 4, 2024

I'm unsure what the naively expected condition should be.
We could also add "1" or check for "set and not empty".

@mikedep333
Copy link
Member

I'm unsure what the naively expected condition should be. We could also add "1" or check for "set and not empty".

we will check for "1" also.

We will not check for "set and not empty" because we do not want "false" to evaluate to "true".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants