Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual bug: No gap between old and new line numbers #18

Open
5 tasks done
icecream17 opened this issue Mar 5, 2023 · 2 comments
Open
5 tasks done

Visual bug: No gap between old and new line numbers #18

icecream17 opened this issue Mar 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@icecream17
Copy link

icecream17 commented Mar 5, 2023

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

image

When looking at a git diff visualization basically (in unstaged or staged changes), if the line number is too big, then the padding has no effect. So there ends up being no gap between the numbers.

image

Pulsar version

1.102.2023021606

Which OS does this happen on?

🪟 Windows

OS details

Microsoft Windows 10 Pro, 10.0.19045 Build 19045

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

  1. This occurs when viewing changes about a git repository, and the file you change must have a lot of lines.
    1. Based on this screenshot, the lines are right-aligned. So idk how long it actually needs to be. My bug originally occured with 6 digits, but maybe fewer is ok. image
    2. I was editing the file set.mm from https://github.com/metamath/set.mm which you can git clone, which easily satisfies the above requirements (700k+ lines and is git repo).
    3. Change whatever long file you choose, and save.
  2. Hover your mouse around the right center portion of the window. A right arrow should pop-up. Click on it to open the git tab. image
  3. On the .git tab, click on the corresponding file. It doesn't matter if it's in "unstaged changes" or "staged changes". You might have to change the branch or repo or something in the dropdown. image
  4. Observe visual bug:
    image

Additional Information:

I'm technically not on the latest rolling release of pulsar

Astonishingly, I can't really find this issue on the archi atom repo. I guess no one edits hundred-thousand-line files.

@icecream17 icecream17 added the bug Something isn't working label Mar 5, 2023
@DeeDeeG
Copy link
Member

DeeDeeG commented Mar 6, 2023

I suppose the gap between the two line numbers needs to be margin, not padding, something like that?

@icecream17
Copy link
Author

I think I found it but I'm not sure how the margin would affect non-long line numbers
https://github.com/pulsar-edit/github/blob/master/styles/file-patch-view.less#L253-L257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants