Split git tab and github integration into separate packages

[sertonix]

Have you checked for existing feature requests?

• Completed

Github package currently provides two different features: a git tab where you can stage changes, push them, etc, and a github integration tab that needs log-in and integrates with other github features.

The idea is to separate them into different packages. That way, people can still use the git integration tab and not worry about github (which, truth to be told, is the package that takes a heavy toll on loading Pulsar) if they don't want to use GitHub

One idea could also be to migrate this new package (the git tab) into something that does not depend on git-utils because of all the problems we faced it. Something like isomorphic-git, that doesn't even depend on the "binary" git being installed on the system could be ideal (but this is kinda a "stretch goal") or to move to a different "git integration" library that's maintained by the community and not something designed "in-house"

Original Message

Summary

Git is a very usefull tool. But it doesn't mean you want to use github.
There are very good reasons to not use it.
Therefor you should be able to have git support in Pulsar without github support.

What benefits does this feature provide?

It would be a sign that the focus of Pulsar is not github.

Any alternatives?

Other examples:

No response

[mauricioszabo]

I don't know what should be done here. Can you provide an example?

Currently, the only github-specific thing on Pulsar is the github package and the backend (the backend we do have plans to change)

[sertonix]

This package provides both the git tab and the github tab.
I suggest splitting the git tab into a seperat package.

[Daeraxa]

I've mentioned it a few times before but I'd actually like to see the GitHub side become a more generic tab that can support multiple hosts/forges/whatever. So you can change it between GitHub/GitLab/Codeberg/Bitbucket etc. modes.

For the sake of playing devil's advocate for this specific idea though, what issue does it actually solve? (Outside of the macOS performance thing which seems to be a bug that doesn't affect all users). As idealistic as I'd love to be, GH is still by far the most popular platform and the one the vast majority of Pulsar users would be using - particularly newer users who the git tab in particular really attracts.

To keep user experience consistent so that the GitHub or Git tab doesn't suddenly "disappear", both would still need to be core packages and it would still look and function identically to how it does currently. If you then disabled the "github" core package the only real difference is that the button at the bottom disappears.

[mauricioszabo]

I actually agree on separating the git tab, honestly 👍

I'm not an user of heavily git integrated tools on my editor, so I never even notice that there was a git tab.

[mauricioszabo]

@sertonix can I rename your issue to reflect what could be done?

[Daeraxa]

For what its worth I also agree it should be split, I think it important we have proper justification recorded when we make such decisions so we can answer them later, hence the devil's advocate question about what benefits splitting it provides vs what problems it could cause.