Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow load times ~ 15 second for every project every time #1070

Open
5 tasks done
srevenant opened this issue Jul 29, 2024 · 1 comment
Open
5 tasks done

Slow load times ~ 15 second for every project every time #1070

srevenant opened this issue Jul 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@srevenant
Copy link

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

Slow load times ~ 15 second for every project every time

Pulsar version

1.119

Which OS does this happen on?

🍎 macOS

OS details

Sonoma

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

start projects. Discussed w/ @savetheclocktower

Additional Information:

No response

@srevenant srevenant added the bug Something isn't working label Jul 29, 2024
@savetheclocktower
Copy link
Sponsor Contributor

@srevenant sent me a profile of a window reload and I noticed this block in the middle:

Screenshot 2024-07-29 at 10 15 30 AM

That's Pulsar hitting NativeCompileCache each time a legacy Tree-sitter grammar is loaded, and taking between 300ms-700ms each time. This block represents 5.5 seconds where the UI is frozen to the user.

I can't find a similar block in my startup profile, even though @srevenant and I are both on Intel Macs running Sonoma. But I have seen this sort of slowdown in the past when I've run an unsigned version of Pulsar, such as one generated from a CI job.

I don't have a good understanding of what invalidates the compile cache (or if this is just a visible symptom of a problem elsewhere), but I might have to go spelunking through the Git history to understand more about NativeCompileCache and the problems it solves. (Here's where it was introduced.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants