Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM upgrade process loses /usr/bin binary #544

Open
5 tasks done
Daeraxa opened this issue May 20, 2023 · 5 comments · May be fixed by #1091 or #543
Open
5 tasks done

RPM upgrade process loses /usr/bin binary #544

Daeraxa opened this issue May 20, 2023 · 5 comments · May be fixed by #1091 or #543
Labels
bug Something isn't working

Comments

@Daeraxa
Copy link
Member

Daeraxa commented May 20, 2023

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

See: https://github.com/orgs/pulsar-edit/discussions/178

On upgrading the .rpm binary the pulsar binary in /usr/bin is lost meaning it can no longer be run from the command line. The .desktop is unaffected as it runs from /opt/pulsar.

See the steps below, shows that the binary itself does work normally as on install it works, just not on upgrade.

I have attempted to fix this in #543 but so far this is failing. I suspect it is because the script can't be found when added to the fpm options? This is only a guess as I noticed (I unfortunately no longer have the logs) that during the actual build process the post-install script is actually in a tmp/ dir.

It doesn't appear this issue is affecting the .deb.

Could possibly be related to the fpm option to remove the buildid? Not sure.

Pulsar version

1.150.0

Which OS does this happen on?

🐧 Red Hat based (Fedora, Alma, RockyLinux, CentOS Stream, etc.)

OS details

Fedora 36

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

  • Download and install Pulsar 1.105.0 e.g (dnf install Linux.pulsar-1.105.0.x86_64)

  • Run which pulsar - should return /usr/bin/pulsar

  • Download and install Pulsar 1.105.2023051902 (dnf install pulsar-1.105.2023052013.x86_64.rpm)

    • dnf output will show that Pulsar has been upgraded.
  • Run which pulsar - should return which: no pulsar in ...

  • Remove pulsar with dnf remove pulsar

  • Reinstall 1.105.2023051902 (dnf install pulsar-1.105.2023052013.x86_64.rpm)

  • Run which pulsar - should return /usr/bin/pulsar

Additional Information:

No response

@Daeraxa Daeraxa added the bug Something isn't working label May 20, 2023
@KarlLevik
Copy link

This still seems to be an issue.

I have just upgraded for the first time. I upgraded from 1.106.0 to 1.107.1.

As root I did dnf install /path/to/file/Linux.pulsar-1.107.1.x86_64.rpm, and now pulsar is no longer in my PATH. (This is on Fedora 38.)

@Daeraxa
Copy link
Member Author

Daeraxa commented Jul 16, 2023

Yeah this is definitely still a problem, I need to have a look at this again, I did try to seek some advice from somebody who knows RPMs far better than I but I wasn't able to get a solution to this (other than package it "properly" and not via electron-builder...). If anyone is an expert then PRs would be gladly accepted.

I'm tempted to add it to some notes on the download page to 1) inform people and 2) see if anyone can assist

@mramendi
Copy link

mramendi commented Feb 8, 2024

This is still a problem. I had 1.105 installed on Fedora, downloaded 1.113, upgraded with dnf, no binary. Removed then installed again (all still with dnf), binary preset and starts

@mramendi
Copy link

This is STILL a problem. I downloaded 1.114, upgraded from 1.113 on Fedora. no binary. Uninstalled, reinstalled, binary works fine.

@mramendi
Copy link

Still a problem when upgrading from 1.114 to to 1.116 on Fedora.

am97 added a commit to am97/pulsar that referenced this issue Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants