Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unallowed characters in username #259

Open
azmeuk opened this issue Jan 5, 2024 · 1 comment
Open

Fix unallowed characters in username #259

azmeuk opened this issue Jan 5, 2024 · 1 comment
Labels
feature New feature or request

Comments

@azmeuk
Copy link
Collaborator

azmeuk commented Jan 5, 2024

Nextcloud does not allow accentuated or special character in the usernames:
nextcloud/server#21313

However sometimes nextcloud-oidc-login is plugged to a IDP where users already have accentuated characters.

I suggest that nextcloud-oidc-login automatically fixes unallowed characters in usernames: replacing accents with unaccented characters and removing other unallowed characters.

@azmeuk azmeuk added the feature New feature or request label Jan 5, 2024
@pulsejet
Copy link
Owner

pulsejet commented Jan 5, 2024

Sounds good. This needs to be configurable since it potentially opens up attack vectors. If the IdP has a user azmeuk, then I can create another user àzmeuk in the IdP and pretend to be azmeuk in Nextcloud.

A possible solution would be to suffix the username with some kind of hash of the original, whenever any transformation is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants