Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible incorrect code snippet #12519

Open
LachlanMarnham opened this issue Aug 14, 2024 · 0 comments
Open

Possible incorrect code snippet #12519

LachlanMarnham opened this issue Aug 14, 2024 · 0 comments
Labels
area/docs Improvements or additions to documentation

Comments

@LachlanMarnham
Copy link

LachlanMarnham commented Aug 14, 2024

File: content/docs/concepts/resources/dynamic-providers.md

Hello. In the GitHub Labels REST API example, it says:

Because the resource provider method implementations will be serialized and used in a different process, we keep all the work to initialize the REST client and to make calls to it, local to each function.

but in the Python example, the GitHub client is created in global scope. In the TypeScript and JavaScript examples the Octokit client is created inside the CRUD methods. So I'm not sure if the Python example is incorrect, or if the explanation I quoted above doesn't apply to Python.

Many thanks

@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Aug 14, 2024
@github-project-automation github-project-automation bot moved this to 🤔 Triage in Docs 📚 Aug 14, 2024
@interurban interurban added area/docs Improvements or additions to documentation and removed needs-triage Needs attention from the triage team labels Aug 26, 2024
@interurban interurban moved this from 🤔 Triage to 🧳 Backlog in Docs 📚 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation
Projects
Status: 🧳 Backlog
Development

No branches or pull requests

2 participants