chore: Replace aws-lambda with @types/aws-lambda #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
/run-example-tests |
|
@astuyve I am going to merge it into this branch so that I can do a new PR so tests will run. |
rshade
added a commit
that referenced
this pull request
Jan 11, 2025
`aws-lambda` is a [poorly-named package](https://www.npmjs.com/package/aws-lambda) which is a CLI tool to deploy Lambda functions and includes heavy dependencies (the entire v2 `aws-sdk`). It also incidentally includes types for Lambda events. The correct package for Lambda event types is `@types/aws-lambda` as per the [docs](https://docs.aws.amazon.com/lambda/latest/dg/typescript-handler.html). This PR adds the correct devDependency and removes the dependency on `aws-lambda` Co-authored-by: AJ Stuyvenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-lambdais a poorly-named package which is a CLI tool to deploy Lambda functions and includes heavy dependencies (the entire v2aws-sdk).It also incidentally includes types for Lambda events.
The correct package for Lambda event types is
@types/aws-lambdaas per the docs.This PR adds the correct devDependency and removes the dependency on
aws-lambda