Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated SDK generation @ aws-cloudformation-user-guide 19dc52cd3f2007d6d268b65b739ffb5ebf8c1e76 #1818

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

pulumi-bot
Copy link
Contributor

Automated PR

Copy link
Contributor

Does the PR have any schema changes?

Found 25 breaking changes:

Resources

  • "aws-native:gamelift:ContainerGroupDefinition":
    • inputs:
      • 🟡 "containerDefinitions" missing
      • 🟡 "schedulingStrategy" missing
      • 🟡 "totalCpuLimit" missing
      • 🟡 "totalMemoryLimit" missing
    • properties:
      • 🟡 "containerDefinitions" missing output "containerDefinitions"
      • 🟡 "schedulingStrategy" missing output "schedulingStrategy"
      • 🟡 "totalCpuLimit" missing output "totalCpuLimit"
      • 🟡 "totalMemoryLimit" missing output "totalMemoryLimit"
  • "aws-native:gamelift:Fleet":
    • 🟡 inputs: "containerGroupsConfiguration" missing
    • 🟡 properties: "containerGroupsConfiguration" missing output "containerGroupsConfiguration"
  • "aws-native:iotwireless:NetworkAnalyzerConfiguration":
    • 🟡 inputs: "tags": items type changed from "#/types/aws-native:index:CreateOnlyTag" to "#/types/aws-native:index:Tag"
    • 🟡 properties: "tags": items type changed from "#/types/aws-native:index:CreateOnlyTag" to "#/types/aws-native:index:Tag"

Types

  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionContainerDefinition" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionContainerDependency" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionContainerDependencyCondition" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionContainerEnvironment" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionContainerHealthCheck" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionContainerPortRange" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionContainerPortRangeProtocol" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionMemoryLimits" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionPortConfiguration" missing
  • 🔴 "aws-native:gamelift:ContainerGroupDefinitionSchedulingStrategy" missing
  • 🔴 "aws-native:gamelift:FleetConnectionPortRange" missing
  • 🔴 "aws-native:gamelift:FleetContainerGroupsConfiguration" missing
  • 🔴 "aws-native:gamelift:FleetContainerGroupsPerInstance" missing
    No new resources/functions.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.65%. Comparing base (5a71999) to head (461faaa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1818   +/-   ##
=======================================
  Coverage   49.65%   49.65%           
=======================================
  Files          43       43           
  Lines        6559     6559           
=======================================
  Hits         3257     3257           
  Misses       3059     3059           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flostadler
Copy link
Contributor

AWS::GameLift::ContainerGroupDefinition started missing the ContainerDefinitions property. Additionally the docs mention the resource is not available even though the API says it is (marked as public/live).

Reached out to AWS. There's no other important changes in the schema so far, so we can wait for AWS to respond: aws-cloudformation/cloudformation-coverage-roadmap#2180

@flostadler
Copy link
Contributor

#1819

@flostadler
Copy link
Contributor

The offending gamelift resource ContainerGroupDefinition, is not usable and incorrectly marked as available in CloudFormation. We can safely upgrade here: #1819 (comment)

@flostadler flostadler merged commit 009d289 into master Nov 12, 2024
18 checks passed
@flostadler flostadler deleted the generate-sdk/11790831925-905 branch November 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants