Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::GameLift::ContainerGroupDefinition missing ContainerDefinitions, TotalMemoryLimitMebibytes and TotalVcpuLimit property #1819

Open
flostadler opened this issue Nov 12, 2024 · 1 comment
Labels
kind/engineering Work that is not visible to an external user

Comments

@flostadler
Copy link
Contributor

flostadler commented Nov 12, 2024

AWS::GameLift::ContainerGroupDefinition started missing the ContainerDefinitions, TotalMemoryLimitMebibytes and TotalVcpuLimit properties in the CloudFormation schema. Additionally the docs mention the resource is not available even though the API says it is (marked as public/live).
This change would break the resource because TotalMemoryLimitMebibytes and TotalVcpuLimit are required properties.

I reached out to AWS about this issue: aws-cloudformation/cloudformation-coverage-roadmap#2180.

Currently this is blocking pulling in new changes from CloudControl (unless we accept the breaking changes). There's no other important changes in the schema so far.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 12, 2024
@flostadler flostadler changed the title AWS::GameLift::ContainerGroupDefinition missing ContainerDefinitions` property AWS::GameLift::ContainerGroupDefinition missing ContainerDefinitions, TotalMemoryLimitMebibytes and TotalVcpuLimit property Nov 12, 2024
@flostadler flostadler added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Nov 12, 2024
@flostadler
Copy link
Contributor Author

Calling CloudControl with a create request returns the following progress event:

"ProgressEvent": {
        "TypeName": "AWS::GameLift::ContainerGroupDefinition",
        "Identifier": "Repro",
        "RequestToken": "bccccfba-13a4-4f6b-9816-44f08b86d623",
        "Operation": "CREATE",
        "OperationStatus": "FAILED",
        "EventTime": "2024-11-12T11:45:05.813000+01:00",
        "StatusMessage": "The Amazon GameLift Containers feature is under improvement. (Service: GameLift, Status Code: 400, Request ID: 1cec4603-4be6-4839-9d9d-348d44425379)",
        "ErrorCode": "AccessDenied"
    }

The CloudFormation API seems to incorrectly label the resource as supported.

We should be good to go forward with the schema change then, but ideally we need some way to mark existing resources as not supported if CloudFormation is incorrectly specifying they are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

2 participants