Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional backof delay for retrying Resource.Get Not Found #1823

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Nov 13, 2024

It appears that the CDK test suite is still failing, so this change adjusts the backoff/retry on Resource.Get to be more generous and allow more time.

https://github.com/pulumi/pulumi-cdk/actions/runs/11818972903/job/32927805461?pr=212

Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.65%. Comparing base (55577fd) to head (8197955).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1823   +/-   ##
=======================================
  Coverage   49.65%   49.65%           
=======================================
  Files          43       43           
  Lines        6559     6559           
=======================================
  Hits         3257     3257           
  Misses       3059     3059           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@blampe blampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a try.

@t0yv0 t0yv0 merged commit 44c2b5b into master Nov 13, 2024
18 checks passed
@t0yv0 t0yv0 deleted the t0yv0/adjust-getresource-retry-2 branch November 13, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants