Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check worktree clean does not detect diffs in the SDKs for missing files #1827

Open
flostadler opened this issue Nov 14, 2024 · 0 comments
Open

Check worktree clean does not detect diffs in the SDKs for missing files #1827

flostadler opened this issue Nov 14, 2024 · 0 comments
Labels
impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user

Comments

@flostadler
Copy link
Contributor

If a file is missing from the sdk folder, the Check worktree clean action does not detect the diff. This is because we're deleting files not tracked in git before running the Check worktree clean action:

pulumi-aws-native/Makefile

Line 116 in 4872ad6

cd sdk/python/ && git clean -fxd

This can cause issues like: #1826 where the python SDK is broken due to missing files.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 14, 2024
@flostadler flostadler added kind/engineering Work that is not visible to an external user impact/reliability Something that feels unreliable or flaky and removed needs-triage Needs attention from the triage team labels Nov 14, 2024
@flostadler flostadler mentioned this issue Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flostadler @pulumi-bot