Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and validate changes related to default tagging behavior #2550

Closed
Tracked by #2539
mnlumi opened this issue Jun 6, 2023 · 3 comments
Closed
Tracked by #2539

Test and validate changes related to default tagging behavior #2550

mnlumi opened this issue Jun 6, 2023 · 3 comments
Assignees
@iwahbe
Labels
6.0 kind/task Work that's part of an ongoing epic
Milestone
0.92

Comments

@mnlumi
Copy link

mnlumi commented Jun 6, 2023 •
edited by kpitzen
Loading

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Test and validate changes related to default tagging behavior
We should verify whether #2549 actually closes out #2533 - ideally by adding a programtest to reproduce the issue, and validating that it passes once the reverted SDK resource is removed.

Affected area/feature
@mnlumi mnlumi added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team 6.0 labels Jun 6, 2023
@mnlumi mnlumi mentioned this issue Jun 6, 2023
Closed
34 tasks
@thomas11 thomas11 removed the needs-triage Needs attention from the triage team label Jun 7, 2023
@mikhailshilkov
Copy link
Member

I tested #2533 manually and it does appear to be fixed. I'll have to think how to write a ProgramTest for it because the issue does not manifest in the Pulumi state - it's only in the actual cloud state where the tags are missing.

@mnlumi
Copy link
Author

mnlumi commented Aug 2, 2023

Let's add a specific test case for this scenario as part of #2539

@iwahbe iwahbe mentioned this issue Aug 4, 2023
Merged
@iwahbe
Copy link
Member

iwahbe commented Aug 4, 2023

Closed by #2655

@iwahbe iwahbe closed this as completed Aug 4, 2023
@mikhailshilkov mikhailshilkov added this to the 0.92 milestone Aug 7, 2023
@mnlumi mnlumi added kind/task Work that's part of an ongoing epic and removed kind/enhancement Improvements or new features labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
6.0 kind/task Work that's part of an ongoing epic
Projects
None yet
Milestone
0.92
Development

No branches or pull requests
4 participants
@thomas11 @mikhailshilkov @iwahbe @mnlumi