Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous <break> markup from NetworkFirewallResourcePolicy #3474

Closed
guineveresaenger opened this issue Feb 23, 2024 · 0 comments · Fixed by #3676
Closed

Remove extraneous <break> markup from NetworkFirewallResourcePolicy #3474

guineveresaenger opened this issue Feb 23, 2024 · 0 comments · Fixed by #3676
Assignees
@guineveresaenger
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@guineveresaenger
Copy link
Contributor

After pulumi/pulumi-terraform-bridge#1689 has merged and is applied we need to edit or possibly remove, depending on upstream, this line from resources.go as the bridge no longer needs placeholders to render an import section correctly.
@guineveresaenger guineveresaenger added the kind/engineering Work that is not visible to an external user label Feb 23, 2024
@guineveresaenger guineveresaenger self-assigned this Mar 18, 2024
@guineveresaenger guineveresaenger mentioned this issue Mar 21, 2024
Merged
guineveresaenger added a commit that referenced this issue Mar 22, 2024
@guineveresaenger
Cleanup: Update import overwrite for Network Firewall Resource Policy (…
7116956 
…#3676)

This issue took a while to fix because the import statement from
upstream is incorrect. We have to keep the overwrite, but make it
conform to new, simpler, formatting expectations. Still an overall
improvement.
Fixes #3474.

Also cleanup docsEdit rule which has been adopted into the bridge to be
generic.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guineveresaenger guineveresaenger

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup: Update import overwrite for Network Firewall Resource Policy pulumi/pulumi-aws
2 participants
@guineveresaenger @pulumi-bot