Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PANIC rendered into examples #3885

Open
t0yv0 opened this issue May 1, 2024 · 0 comments
Open

PANIC rendered into examples #3885

t0yv0 opened this issue May 1, 2024 · 0 comments
Labels
area/examples awaiting/codegen Blocked on a missing bug or feature in SDK generation impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec language/java

Comments

@t0yv0
Copy link
Member

t0yv0 commented May 1, 2024

What happened?

We have some examples that render PANIC into registry docs under the Java tab.

Starting from pulumi/pulumi-random#890 suggestion I've attempted to fix these by upgrading K8S and local/null references and rebuilding. This fixes some but still leaves 16 examples.

Three are not explained yet perhaps will only reproduce after another AWS release to updated upstream:

ex-9:

resource "aws_sagemaker_app_image_config" "test" {
  app_image_config_name = "example"

  kernel_gateway_image_config {
    kernel_spec {
      name = "example"
    }
  }
}

ex-10:

resource "aws_sagemaker_app_image_config" "test" {
  app_image_config_name = "example"

  kernel_gateway_image_config {
    kernel_spec {
      name = "example"
    }

    file_system_config {}
  }
}

ex-13:

resource "aws_sagemaker_image" "example" {
  image_name = "example"
  role_arn   = aws_iam_role.example.arn
}

resource "aws_sagemaker_app_image_config" "example" {
  app_image_config_name = "example"

  kernel_gateway_image_config {
    kernel_spec {
      name = "example"
    }
  }
}

resource "aws_sagemaker_image_version" "example" {
  image_name = aws_sagemaker_image.example.id
  base_image = "base-image"
}

resource "aws_sagemaker_domain" "example" {
  domain_name = "example"
  auth_mode   = "IAM"
  vpc_id      = aws_vpc.example.id
  subnet_ids  = [aws_subnet.example.id]

  default_user_settings {
    execution_role = aws_iam_role.example.arn

    kernel_gateway_app_settings {
      custom_image {
        app_image_config_name = aws_sagemaker_app_image_config.example.app_image_config_name
        image_name            = aws_sagemaker_image_version.example.image_name
      }
    }
  }
}

The rest are likely issues of in the Java converter, filed in:

pulumi/pulumi-java#1346
pulumi/pulumi-java#1347
pulumi/pulumi-java#1348
pulumi/pulumi-java#1349
pulumi/pulumi-java#1350
pulumi/pulumi-java#1351
pulumi/pulumi-java#1352
pulumi/pulumi-java#1353
pulumi/pulumi-java#1354
pulumi/pulumi-java#1355

When this is done we should not have anything show up for git grep PANIC query on the repo.

Example

See above.

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels May 1, 2024
@t0yv0 t0yv0 added area/examples language/java impact/usability Something that impacts users' ability to use the product easily and intuitively and removed needs-triage Needs attention from the triage team labels May 2, 2024
@t0yv0 t0yv0 added the awaiting/codegen Blocked on a missing bug or feature in SDK generation label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples awaiting/codegen Blocked on a missing bug or feature in SDK generation impact/usability Something that impacts users' ability to use the product easily and intuitively kind/bug Some behavior is incorrect or out of spec language/java
Projects
None yet
Development

No branches or pull requests

1 participant