Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regress-4457 failing when new properties are introduced for autoscaling.Group #4958

Open
flostadler opened this issue Dec 20, 2024 · 0 comments
Open

Fix regress-4457 failing when new properties are introduced for autoscaling.Group #4958

flostadler opened this issue Dec 20, 2024 · 0 comments
Labels
impact/flaky-test A test that is unreliable kind/engineering Work that is not visible to an external user

Comments

@flostadler
Copy link
Contributor

regress-4457 is failing when a new property is added to autoscaling.Group. That test is executing pulumi import and then editing the code to add the necessary changes. The problem is that our python tests use the latest release version of the SDK and that does not include newly added properties, but pulumi import will include them in the generated code.

We should rewrite that test to use nodejs (or yaml?) because they are not susceptible to this issue.
@flostadler flostadler added impact/flaky-test A test that is unreliable kind/engineering Work that is not visible to an external user labels Dec 20, 2024
@flostadler flostadler mentioned this issue Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact/flaky-test A test that is unreliable kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flostadler