-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update images to unify usage of ENTRYPOINT and CMD #270
Labels
kind/enhancement
Improvements or new features
Comments
julienp
added
kind/enhancement
Improvements or new features
and removed
needs-triage
Needs attention from the triage team
labels
Sep 6, 2024
Thinking some more about this, we can't change this without breaking backwards compatibility. |
julienp
changed the title
Update images to use
Update images to unify usage of ENTRYPOINT and CMD
Sep 6, 2024
pulumi
as entrypoint, not command
julienp
added a commit
that referenced
this issue
Sep 24, 2024
This is outdated/wrong, some images use ENTRYPOINT, others use CMD. #270 tracks unifying/rethinking this.
julienp
added a commit
that referenced
this issue
Sep 24, 2024
This is outdated/wrong, some images use ENTRYPOINT, others use CMD. #270 tracks unifying/rethinking this.
Source-Controller
pushed a commit
to Source-Controller/Pulumi-Docker
that referenced
this issue
Oct 17, 2024
This is outdated/wrong, some images use ENTRYPOINT, others use CMD. pulumi/pulumi-docker-containers#270 tracks unifying/rethinking this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our images set
CMD ["pulumi"]
, except the kitchen sink, which setsENTRYPOINT ["pulumi"]
.CMD
sets the arguments that are passed to theENTRYPOINT
. The default entrypoint is usuallybash -c
.The README says (outdated, obviously):
The base image for Python sets
CMD ["python"]
, overriding that toCMD ["pulumi"]
makes some sense, if youdocker run
with no other arguments, it prints the pulumi CLI help, rather than starting a python interpreter.Setting the entrypoint to
pulumi
means when you rundocker run $IMG version
and it will essentially runpulumi version
. At first glance, that seems useful, for example you just passup
to run an update, but in practice you might need to runpulumi install
first. Now you're forced to override the entrypoint:docker run --entrypoint bash pulumi/pulumi -c "pulumi install && pulumi up --yes"
(note that awkward arguments-c "..."
).The text was updated successfully, but these errors were encountered: