Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The EKS resource provider should return the schema from GetSchema #659

Closed
justinvp opened this issue Feb 10, 2022 · 0 comments · Fixed by #660
Closed

The EKS resource provider should return the schema from GetSchema #659

justinvp opened this issue Feb 10, 2022 · 0 comments · Fixed by #660
Assignees
@stack72
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.68

Comments

@justinvp
Copy link
Member

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

We should ensure the resource provider for EKS is returning its schema from GetSchema. We could do so in a manner similar to how we'd do it from the TS boilerplate: pulumi/pulumi-component-provider-ts-boilerplate#8
@justinvp justinvp added the kind/enhancement Improvements or new features label Feb 10, 2022
stack72 added a commit that referenced this issue Feb 10, 2022
@stack72
Ensure schema is available in Provider for use in GetSchema calls
b695e59 
Fixes: #659

We need to take a copy of the schema.json file for use in reading
the file to pass to the Provider for use in GetSchema
@stack72 stack72 mentioned this issue Feb 10, 2022
Merged
@stack72 stack72 self-assigned this Feb 10, 2022
@stack72 stack72 added this to the 0.68 milestone Feb 10, 2022
stack72 added a commit that referenced this issue Feb 10, 2022
@stack72
Ensure schema is available in Provider for use in GetSchema calls
1e1b4c5 
Fixes: #659

We need to take a copy of the schema.json file for use in reading
the file to pass to the Provider for use in GetSchema
stack72 added a commit that referenced this issue Feb 10, 2022
@stack72
Ensure schema is available in Provider for use in GetSchema calls
74a4f63 
Fixes: #659

We need to take a copy of the schema.json file for use in reading
the file to pass to the Provider for use in GetSchema
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stack72 stack72

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.68
Development

Successfully merging a pull request may close this issue.

Ensure schema is available in Provider for use in GetSchema calls pulumi/pulumi-eks
3 participants
@stack72 @justinvp @pulumi-bot