Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous subtests #2711

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Anonymous subtests #2711

merged 1 commit into from
Dec 9, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 9, 2024

Use the default subtest name in TestSecretsInPlainTextNote. The current name causes gotestfmt to erroneously decide
TestSecretsInPlainTextNote/Some_other_text.__~>_**Warning:**_All_a... has failed:

Screenshot 2024-12-09 at 10 33 38 AM

Tests (when passing) now look like this:
Screenshot 2024-12-09 at 12 21 22 PM

Use the default subtest name in `TestSecretsInPlainTextNote`. The current name causes
`gotestfmt` to erroneously decide
`TestSecretsInPlainTextNote/Some_other_text.__~>_**Warning:**_All_a...` has failed.
@iwahbe iwahbe self-assigned this Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe requested a review from a team December 9, 2024 11:20
@iwahbe iwahbe merged commit ce15c24 into master Dec 9, 2024
24 checks passed
@iwahbe iwahbe deleted the iwahbe/anonymous-subtests branch December 9, 2024 11:52
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v8.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants