Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform provider google beta to v6.13.0 #2733

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Upgrade terraform provider google beta to v6.13.0 #2733

merged 3 commits into from
Dec 16, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 12, 2024 •
edited by guineveresaenger
Loading

This pull request needs the bridge changes from pulumi/pulumi-terraform-bridge#2738.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Does the PR have any schema changes?

Found 13 breaking changes:

Types

  • "gcp:compute/getInstanceAdvancedMachineFeature:getInstanceAdvancedMachineFeature": required:
    • 🟢 "enableUefiNetworking" property has changed to Required
    • 🟢 "performanceMonitoringUnit" property has changed to Required
  • "gcp:compute/getInstanceTemplateAdvancedMachineFeature:getInstanceTemplateAdvancedMachineFeature": required:
    • 🟢 "enableUefiNetworking" property has changed to Required
    • 🟢 "performanceMonitoringUnit" property has changed to Required
  • "gcp:compute/getRegionInstanceTemplateAdvancedMachineFeature:getRegionInstanceTemplateAdvancedMachineFeature": required:
    • 🟢 "enableUefiNetworking" property has changed to Required
    • 🟢 "performanceMonitoringUnit" property has changed to Required
  • 🟢 "gcp:compute/getSecurityPolicyAdaptiveProtectionConfigLayer7DdosDefenseConfig:getSecurityPolicyAdaptiveProtectionConfigLayer7DdosDefenseConfig": required: "thresholdConfigs" property has changed to Required
  • 🟢 "gcp:container/getClusterNodeConfig:getClusterNodeConfig": required: "localSsdEncryptionMode" property has changed to Required
  • 🟢 "gcp:container/getClusterNodePoolAutoConfig:getClusterNodePoolAutoConfig": required: "linuxNodeConfigs" property has changed to Required
  • 🟢 "gcp:container/getClusterNodePoolNodeConfig:getClusterNodePoolNodeConfig": required: "localSsdEncryptionMode" property has changed to Required
  • 🟢 "gcp:oracledatabase/getAutonomousDatabasesAutonomousDatabase:getAutonomousDatabasesAutonomousDatabase": required: "deletionProtection" property has changed to Required
  • 🟢 "gcp:oracledatabase/getCloudExadataInfrastructuresCloudExadataInfrastructure:getCloudExadataInfrastructuresCloudExadataInfrastructure": required: "deletionProtection" property has changed to Required
  • 🟢 "gcp:oracledatabase/getCloudVmClustersCloudVmCluster:getCloudVmClustersCloudVmCluster": required: "deletionProtection" property has changed to Required

New resources:

  • gemini/codeRepositoryIndex.CodeRepositoryIndex
  • gemini/repositoryGroup.RepositoryGroup
  • gemini/repositoryGroupIamBinding.RepositoryGroupIamBinding
  • gemini/repositoryGroupIamMember.RepositoryGroupIamMember
  • gemini/repositoryGroupIamPolicy.RepositoryGroupIamPolicy
  • iam/projectsPolicyBinding.ProjectsPolicyBinding
  • networksecurity/mirroringDeployment.MirroringDeployment
  • networksecurity/mirroringDeploymentGroup.MirroringDeploymentGroup
  • networksecurity/mirroringEndpointGroup.MirroringEndpointGroup
  • networksecurity/mirroringEndpointGroupAssociation.MirroringEndpointGroupAssociation
  • tpu/v2QueuedResource.V2QueuedResource

New functions:

  • backupdisasterrecovery/getBackup.getBackup
  • backupdisasterrecovery/getBackupVault.getBackupVault
  • gemini/getRepositoryGroupIamPolicy.getRepositoryGroupIamPolicy

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe marked this pull request as draft December 12, 2024 13:49
@iwahbe iwahbe force-pushed the iwahbe/wip-upgrade-terraform-provider-google-beta-to-v6.13.0 branch from e9aa3fb to 677ae54 Compare December 12, 2024 14:17
@iwahbe iwahbe mentioned this pull request Dec 12, 2024
Merged
iwahbe added a commit to pulumi/pulumi-terraform-bridge that referenced this pull request Dec 13, 2024
@iwahbe
Call configure in sequence (instead of in parallel) (#2738)
b9a6a39 
It looks like GCP has [introduced a
dependency](hashicorp/terraform-provider-google-beta#8747)
on configuring SDK and then PF into their provider. This commit is being
used to check if ordering will fix the panics that the GCP upgrade is
seeing in tests.

pulumi/pulumi-gcp#2733 shows that this is a
necessary change.
@guineveresaenger guineveresaenger added the awaiting/bridge The issue cannot be resolved without action in pulumi-terraform-bridge. label Dec 16, 2024
@guineveresaenger guineveresaenger force-pushed the iwahbe/wip-upgrade-terraform-provider-google-beta-to-v6.13.0 branch from 677ae54 to 09a7424 Compare December 16, 2024 19:52
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f2669f7) to head (09a7424).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #2733   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines         161     161           
======================================
  Misses        161     161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guineveresaenger guineveresaenger marked this pull request as ready for review December 16, 2024 20:04
@guineveresaenger guineveresaenger merged commit 9e113b7 into master Dec 16, 2024
25 checks passed
@guineveresaenger guineveresaenger deleted the iwahbe/wip-upgrade-terraform-provider-google-beta-to-v6.13.0 branch December 16, 2024 21:38
@guineveresaenger guineveresaenger changed the title WIP upgrade terraform provider google beta to v6.13.0 Upgrade terraform provider google beta to v6.13.0 Dec 16, 2024
This was referenced Dec 16, 2024
Closed
Closed
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v8.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting/bridge The issue cannot be resolved without action in pulumi-terraform-bridge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwahbe @pulumi-bot @guineveresaenger