Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example S3 code is invalid. #1420

Open
Myslawek opened this issue Aug 21, 2024 · 3 comments
Open

Example S3 code is invalid. #1420

Myslawek opened this issue Aug 21, 2024 · 3 comments
Labels
area/codegen kind/bug Some behavior is incorrect or out of spec

Comments

@Myslawek
Copy link

Myslawek commented Aug 21, 2024

File: themes/default/content/registry/packages/aws/api-docs/s3/bucketpolicy/_index.md

The example provided for S3 bucket policy in Java is invalid. GetPolicyDocumentStatementArgs does not accept a List of Output<String> (List<Output<String>>) as the example implies. Instead it accepts Output<List<String>>. Current solution cannot be used at all, since it won't compile.

.applyValue(getPolicyDocumentResult -> getPolicyDocumentResult) is redundant. It does not mutate or does anything to the value itself.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Aug 21, 2024
@Myslawek Myslawek changed the title Example code is invalid. Example S3 code is invalid. Aug 21, 2024
@interurban interurban added kind/bug Some behavior is incorrect or out of spec and removed needs-triage Needs attention from the triage team labels Aug 26, 2024
@interurban interurban transferred this issue from pulumi/registry Aug 29, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Aug 29, 2024
@interurban
Copy link

Talked with Matt and it looks like this one would most likely be a converter bug or maybe a codegen bug. Adding it to the right triage team.

@interurban
Copy link

Thank you @Myslawek . I imagine your not blocked by this, but if you need any help let me know. I've routed this to the team to see why this particular example didn't convert properly.

@Frassle
Copy link
Member

Frassle commented Aug 30, 2024

This looks like a codegen bug to me, moving to java repo.

@Frassle Frassle transferred this issue from pulumi/pulumi-converter-terraform Aug 30, 2024
@justinvp justinvp added area/codegen and removed needs-triage Needs attention from the triage team labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen kind/bug Some behavior is incorrect or out of spec
Projects
Status: 🎬 Ready
Development

No branches or pull requests

5 participants