-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating workflow for multiple emails always detects changes to apply #551
Comments
Hi,
This happens on every run. I assume it is related to the following issues on the Terraform Bridge project -
Runtime information:
Is there a possible workaround to this? |
For posterity I had the same issue with properties of both NotificationDestination and NotificationChannel, a change was always detected. Not sure it helps for the current problem but for those poor fellow loving the satisfying "no change detected" who may end up in the thread with a similar problem. It turned out it was the bridge adding this extra property every time :
simply adding it to the property array 1rst position made no more change detected. |
@jodem, can you elaborate on where you added this value? |
@estiller sure, As I said it's on the notification destination object I had a change detected all the time until I added an extra property.
|
Thanks, @jodem. In our case, we use a Slack destination, so it's manually created, and we can't modify it in code. |
Hi @mariuszniemiec-wl. Thanks for opening an issue. I suspect that this is a bridge that has to do with set diffs. This might have improved in more modern version of pulumi-newrelic. Has anyone replicated the issue on a recent version of pulumi-newrelic? Edit: pulumi-cloudflare -> pulumi-newrelic |
Hi @iwahbe, I assume you mean "more modern version of
This keeps happening, no matter how many times I try deploy. The workaround mentioned by @jodem solves this. |
@estiller I did mean "pulumi-newrelic". Sorry about that. Thanks for checking that this still occurs. |
sorry for late answer, I had no time to answer earlier. I confirm issue is stil here, I updated all node package.json including main pulumi as well as pulumi-newrelic. |
Hi @mariuszniemiec-wl. Does the issue still reproduce on v5.32.1? We just released an improvement to this providers diff implementation, and it fixed a similar problem. |
Wonderful and big thanks. This now works as expected. 🎉 |
What happened?
I tried to create notification workflow, with use of emails list from configuration (see code below).
However pulumi always see diff in destination IDs array like shown in example below.
Used resources are:
Problem is in diff that creates Workflow resource.
Example
Following code:
Pulumi preview, always show (even after up and applying changes):
Output of
pulumi about
CLI
Version 3.92.0
Go Version go1.21.3
Go Compiler gc
Plugins
NAME VERSION
newrelic 5.15.2
nodejs unknown
Host
OS ubuntu
Version 22.04
Arch x86_64
This project is written in nodejs: executable='/bin/node' version='v16.20.2'
Current Stack: organization/pulumi-newrelic-widelab/dev
TYPE URN
pulumi:pulumi:Stack urn:pulumi:dev::pulumi-newrelic-widelab::pulumi:pulumi:Stack::pulumi-newrelic-widelab-dev
pulumi:providers:newrelic urn:pulumi:dev::pulumi-newrelic-widelab::pulumi:providers:newrelic::default_5_15_2
newrelic:index/notificationDestination:NotificationDestination urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:index/notificationDestination:NotificationDestination::[email protected]
newrelic:synthetics/monitor:Monitor urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:synthetics/monitor:Monitor::httpMonitor
newrelic:synthetics/certCheckMonitor:CertCheckMonitor urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:synthetics/certCheckMonitor:CertCheckMonitor::sslMonitor
newrelic:index/alertPolicy:AlertPolicy urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:index/alertPolicy:AlertPolicy::notificationPolicy
newrelic:index/notificationDestination:NotificationDestination urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:index/notificationDestination:NotificationDestination::[email protected]
newrelic:index/notificationChannel:NotificationChannel urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:index/notificationChannel:NotificationChannel::[email protected]
newrelic:synthetics/alertCondition:AlertCondition urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:synthetics/alertCondition:AlertCondition::sslAlertCondition
newrelic:synthetics/alertCondition:AlertCondition urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:synthetics/alertCondition:AlertCondition::httpAlertCondition
newrelic:index/notificationChannel:NotificationChannel urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:index/notificationChannel:NotificationChannel::[email protected]
newrelic:index/workflow:Workflow urn:pulumi:dev::pulumi-newrelic-widelab::newrelic:index/workflow:Workflow::alertNotificationWorkflow
Found no pending operations associated with dev
Backend
Name mario
URL file://~/Work/pulumi-states/pulumi-newrelic-widelab
User mario
Organizations
Token type personal
Dependencies:
NAME VERSION
@types/node 16.18.59
@pulumi/newrelic 5.15.2
@pulumi/pulumi 3.92.0
Pulumi locates its logs in /tmp by default
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: