Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conduct an audit of the whole codebase, verifying secrets are used properly #382

Open
IaroslavTitov opened this issue Aug 14, 2024 · 2 comments
Assignees
Labels
kind/engineering Work that is not visible to an external user

Comments

@IaroslavTitov
Copy link
Contributor

IaroslavTitov commented Aug 14, 2024

Ask

Recently we had an incident where improper marshaling settings resulted in secrets leaking - #381

  • Conduct an audit of the whole projects, making sure secrets are properly treated. Possibly, we can replace all MarshalSettings with a const to avoid such issues in the future.
  • Add tests that verify secrets are kept hidden to avoid regressions like this
@IaroslavTitov IaroslavTitov self-assigned this Aug 14, 2024
@aureq
Copy link
Member

aureq commented Aug 15, 2024

@IaroslavTitov Do you think #384 should be looked at as part of this issue?

@IaroslavTitov
Copy link
Contributor Author

@IaroslavTitov Do you think #384 should be looked at as part of this issue?

Potentially yes. If the config secret way I linked in that issue doesn't work, then that issue is a security hole somewhere, but I'm hoping it works

@cleverguy25 cleverguy25 added the kind/engineering Work that is not visible to an external user label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

3 participants