-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure # Configuration
section of README.md is up to date
#1585
Comments
Could we just direct to registry where this information is already up-to-date by construction? And delete from README. |
I don't see where this information is in the registry, but I agree that the registry is the natural place for it. |
For GCP it's linked here: For Auth0 it's harder to find it seems but it's found here: |
I think it needs to be easy to find and speak directly to the Pulumi..yaml configuration before we can swap out. For GCP, that is hand written (and probably out of date). |
Sadness.. you're probably right. |
Related to this, it would be nice to surface warnings across all providers such as pulumi/pulumi-hcloud#368. Right now this is impossible. I think it is generically worth it to let the bridge manage some section of the README.md. To allow a normal README.md to exist, we can surround the bridge section with some commented out fence. <!-- pulumi-terraform-bridge: start -->
## Configuration
...
## Caveats
### Python
Right now, pulumi_${PROVIDER} does not support python 3.12. See ${ISSUE} for details.
<!-- pulumi-terraform-bridge: end --> |
That's a nice use case indeed, good thinking there. Are you sure there's no GitHub mechanisms to communicate instead like pinned issues? Having files that combine auto generated sections with source-of-truth content is always a little tricky to explain, and since the bridge is used outside of our org there's always that, though of course we can keep such features flagged and internal. |
None that are great. We could write a script that would create an issue in each provider, then pin it, but that's not a great solution. More importantly, it would be a worse solution than sticking the warning in the README.md. There are other places where we want to make bulk readme changes. For example, pulumi-hcloud mentions how to install in multiple languages (but not java). It doesn't link to it's registry entry. |
This will not work for all provider. Ex. in pulumi-github: The configuration section has the env var names which can be used instead of the provider config but the schema does not: https://github.com/pulumi/pulumi-github/blob/632c46d96b5ca28d396de50d66beb44ba25b9bd3/provider/cmd/pulumi-resource-github/schema.json#L51 This means that if we auto-generate the Configuration section from the schema, we'd regress on this. We might be able to fix this with a check on PRs, similar to what we have for breaking changes - all configuration options should have an entry in the README. |
# Configuration
section of README.md# Configuration
section of README.md is up to date
I got a CI check working in pulumi/pulumi-github#615 - it just checks that each config option is mentioned in the Configuration section. I think it's simple and should help us keep these sections up to date. I don't see an automatic solution working without pulumi/registry#4749 since it is the upstream docs which have the detailed explanations of each option, which is not always in the schema. I'll lift the check into ci-mgmt. |
A CI check is a good place to start, though I continue to believe we will need to find a way to automate this in the future. This will help us calibrate how badly we are behind here. |
fixes pulumi/pulumi-terraform-bridge#1585 This PR adds a check in bridged provider CI for configuration options in README.md. CI will now comment on PRs if any configuration options are missing in the README.md Tested in pulumi/pulumi-github#615 and pulumi/pulumi-xyz#31
Hello!
Issue details
Each bridged provider has a configuration section for setting up the provider. This is manually copied from TF, and not automatically updated. It looks like this (for auth0):
As part of an update, the bridge should re-derive the configuration section from
schema.json
and update README.md. This is necessary to keep our provider documentation up to date in a world of automatic updates.Affected area/feature
The text was updated successfully, but these errors were encountered: