Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor custom timeouts support to match TF #2411

Open
t0yv0 opened this issue Sep 11, 2024 · 0 comments
Open

Refactor custom timeouts support to match TF #2411

t0yv0 opened this issue Sep 11, 2024 · 0 comments
Labels
kind/design An engineering design doc, usually part of an Epic kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Sep 11, 2024

Logging a design conversation from reviewing #2407

There are now good tests to cover Custom Timeout support. But there is one concern introduced in 2407. Currently timeouts are read through the InstanceDiff object from the planning phase and re-injected in PlannedPrivate.

This must not be how TF CLI operates itself, since the TF CLI cannot observe the InstanceDiff object and instead operates primarily via the TF gRPC protocol.

Likewise, PF resources and "any provider" support operates purely off gRPC protocol and must implement timeouts in a different way.

This task is a reminder to factor custom timeouts support to match how TF does it without relying on the InstanceDiff object, and to confirm it works for the PF case as well.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 11, 2024
@guineveresaenger guineveresaenger added kind/engineering Work that is not visible to an external user kind/design An engineering design doc, usually part of an Epic and removed needs-triage Needs attention from the triage team labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design An engineering design doc, usually part of an Epic kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

3 participants