Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate lint rules #2474

Open
blampe opened this issue Oct 10, 2024 · 0 comments
Open

Consolidate lint rules #2474

blampe opened this issue Oct 10, 2024 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@blampe
Copy link
Contributor

blampe commented Oct 10, 2024

We currently have a lot of submodules with their own .golangci.yaml configurations -- in particular test directories which ignore things like lll.

The lint script uses the presence of a go.mod file to determine which lint configuration to use, but it would be better to have one configuration for the repo with explicit exclusions -- ideally in the form of //nolint:lll // Explanation. comments.
@blampe blampe added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Oct 10, 2024
@iwahbe iwahbe added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team kind/enhancement Improvements or new features labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blampe @iwahbe