Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Cross-testing coverage for Delete #2859

Open
iwahbe opened this issue Jan 21, 2025 · 0 comments
Open

[EPIC] Cross-testing coverage for Delete #2859

iwahbe opened this issue Jan 21, 2025 · 0 comments
Labels
kind/epic Large new features or investments

Comments

@iwahbe
Copy link
Member

iwahbe commented Jan 21, 2025

What goes up must come down, even Pulumi programs.

Similar to #2537, we need comprehensive cross-tests for the Delete verb. We should have cross-tests for the same set of inputs that are used in the Create tests. Helpfully, those are already listed for Create.

Instead of writing separate tests for create and delete, we should write a single crosstest.CreateAndDelete case1 (per library: SDKv2 and PF) and convert create tests described in #2537 to that function.

Footnotes

  1. We can continue to expose crosstest.Create and expose crosstest.Delete, but they should be rarely used.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Jan 21, 2025
@iwahbe iwahbe added kind/epic Large new features or investments and removed needs-triage Needs attention from the triage team labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Large new features or investments
Projects
None yet
Development

No branches or pull requests

2 participants