Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the AWS 6.0 migration guide for correctness #3085

Closed
Tracked by #2753
cnunciato opened this issue Aug 30, 2023 · 4 comments
Closed
Tracked by #2753

Review the AWS 6.0 migration guide for correctness #3085

cnunciato opened this issue Aug 30, 2023 · 4 comments
Assignees
@lukehoban
Labels
area/docs Hand-written documentation. For api docs, see area/api-docs. kind/bug Some behavior is incorrect or out of spec resolution/wont-fix This issue won't be fixed

Comments

@cnunciato
Copy link
Contributor

cnunciato commented Aug 30, 2023 •
edited
Loading

In addressing pulumi/docs#9764, we noticed a few things about the AWS 5.x to 6.x migration guide that aren't correct. For example, the PeeringAttachment resource exists, but the link in the guide points to something called PeeringAttachmentAcceptor; the "from" and "to" names are identical for ListenerCertificate and TargetGroupAttachment, etc.) We should go through this guide in detail and make sure it's accurate.
@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Aug 30, 2023
@cnunciato cnunciato transferred this issue from pulumi/docs Aug 30, 2023
@mnlumi mnlumi mentioned this issue Aug 31, 2023
Closed
14 tasks
@1oglop1
Copy link

1oglop1 commented Oct 3, 2023

@cnunciato I just noticed a lot of breaking changes in typescript
eg. aws.types.input.ecs.ClusterDefaultCapacityProviderStrategy -> aws.types.input.ecs.ClusterCapacityProvidersDefaultCapacityProviderStrategy
none of this is mentioned in the migration guide

@joeduffy
Copy link
Member

@lukehoban @mnlumi Can we put this on deck so folks facing the upgrade have everything they need?

@toriancrane toriancrane added kind/bug Some behavior is incorrect or out of spec area/registry area/docs Hand-written documentation. For api docs, see area/api-docs. and removed needs-triage Needs attention from the triage team labels Oct 25, 2023
@toriancrane toriancrane moved this from 🤔 Triage to 🎬 Ready in Docs 📚 Oct 25, 2023
@iwahbe
Copy link
Member

iwahbe commented Nov 12, 2024

I think this is sufficiently old that we can close it. pulumi-aws is on v6.59.0.

@iwahbe iwahbe closed this as completed Nov 12, 2024
@github-project-automation github-project-automation bot moved this from 🎬 Ready to 🏁 Done in Docs 📚 Nov 12, 2024
@pulumi-bot pulumi-bot reopened this Nov 12, 2024
@pulumi-bot
Copy link
Collaborator

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Nov 12, 2024
@iwahbe iwahbe added resolution/wont-fix This issue won't be fixed and removed needs-triage Needs attention from the triage team labels Nov 12, 2024
@iwahbe iwahbe closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukehoban lukehoban

Labels
area/docs Hand-written documentation. For api docs, see area/api-docs. kind/bug Some behavior is incorrect or out of spec resolution/wont-fix This issue won't be fixed
Projects
Docs 📚
Status: 🏁 Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lukehoban @cnunciato @joeduffy @1oglop1 @toriancrane @iwahbe @pulumi-bot