Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failed logo checks #3718

Closed
cnunciato opened this issue Jan 3, 2024 · 0 comments · Fixed by #3719
Closed

Ignore failed logo checks #3718

cnunciato opened this issue Jan 3, 2024 · 0 comments · Fixed by #3719
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone

Comments

@cnunciato
Copy link
Contributor

Our newly added link checker is currently failing on packages that don't have logo URLs. We should add an exception to tolerate these, since the UI currently handles them automatically (by falling back to a placeholder icon).

@github-project-automation github-project-automation bot moved this to 🤔 Triage in Docs 📚 Jan 3, 2024
@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Jan 3, 2024
@cnunciato cnunciato added the kind/engineering Work that is not visible to an external user label Jan 3, 2024
@cnunciato cnunciato removed the needs-triage Needs attention from the triage team label Jan 3, 2024
@cnunciato cnunciato added this to the 0.98 milestone Jan 3, 2024
@cnunciato cnunciato self-assigned this Jan 3, 2024
@cnunciato cnunciato moved this from 🤔 Triage to 💜 Review in Docs 📚 Jan 3, 2024
@github-project-automation github-project-automation bot moved this from 💜 Review to 🏁 Done in Docs 📚 Jan 4, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 4, 2024
@cnunciato cnunciato added the size/S Estimated effort to complete (1-2 days). label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants