-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation message rendering #3972
Labels
area/api-docs
Generated API docs, generated from providers. For hand-written docs, see area/docs.
kind/bug
Some behavior is incorrect or out of spec
resolution/fixed
This issue was fixed
Milestone
Comments
sean1588
added
kind/enhancement
Improvements or new features
needs-triage
Needs attention from the triage team
labels
Feb 14, 2024
After doing a bit of investigation it looks like the trailing "\n" from the property description messes with the markdown rendering. After removing it the text appears correctly in the box, but we lose the description formatting. I'm looking into a solution here. |
sean1588
added
kind/bug
Some behavior is incorrect or out of spec
area/api-docs
Generated API docs, generated from providers. For hand-written docs, see area/docs.
and removed
kind/enhancement
Improvements or new features
needs-triage
Needs attention from the triage team
labels
Feb 14, 2024
this has definitely been reported multiple times (including once by me!)
... #3008 is one example if you're
looking for previous fix attempts at similar stuff
…On Wed, Feb 14, 2024 at 1:53 PM Sean Holung ***@***.***> wrote:
After doing a bit of investigation it looks like the trailing "\n" from
the property description messes with the markdown rendering. After removing
it the text appears correctly in the box, but we loose the description
formatting. I'm looking into a solution here.
—
Reply to this email directly, view it on GitHub
<#3972 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB77TQVVQWFOLSEF5SJ5IE3YTUW6ZAVCNFSM6AAAAABDJFP6OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUG4ZDQNZYGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
thank you @ericrudder, I'll take a look at that. |
Cannot close issue:
Please fix these problems and try again. |
sean1588
added
resolution/fixed
This issue was fixed
and removed
needs-triage
Needs attention from the triage team
labels
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api-docs
Generated API docs, generated from providers. For hand-written docs, see area/docs.
kind/bug
Some behavior is incorrect or out of spec
resolution/fixed
This issue was fixed
I am 99% sure there is already an issue for this, but I cannot seem to track it down. Deprecation messages sometimes render strangely outside of its formatted box:
The text was updated successfully, but these errors were encountered: