Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: scripts/config_version.rb - Useless assignment to variable - e. #66

Closed
TJM opened this issue May 8, 2018 · 5 comments
Closed

Comments

@TJM
Copy link

TJM commented May 8, 2018

According to pdk validate (after running pdk convert)...

warning: rubocop: scripts/config_version.rb:5:21: Lint/UselessAssignment: Useless assignment to variable - `e`.
@Nekototori
Copy link

While I think rubocop error is good to fix, I'd argue that pdk isn't the appropriate tool for testing a control repo.

@natemccurdy
Copy link
Contributor

Fixed in 36a2784

Thanks for the report @TJM

@TJM
Copy link
Author

TJM commented May 8, 2018

@Nekototori - PDK's control-repo capability is under development or at least consideration: puppetlabs/pdk#333

It already works just fine for pdk validate (and pdk convert makes it super easy), but I am not saying it couldn't be better (Puppetfile validation, etc) :)

@TJM
Copy link
Author

TJM commented May 8, 2018

Thanks @natemccurdy !

@Nekototori
Copy link

@TJM Thanks for the pointer. I see someone mentioned onceover which is generally what I recommend using for testing control repo. It handles Puppetfile validation, as well as quickly allowing you to update the modules in the Puppetfile and straight into testing how your puppetcode will handle the upgrade (in case there are changed/depreciated commands, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants