Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slash_comments incorrectly fix "puppet:///file" #110

Open
zombiedk opened this issue Mar 22, 2023 · 1 comment
Open

slash_comments incorrectly fix "puppet:///file" #110

zombiedk opened this issue Mar 22, 2023 · 1 comment
Labels
bug Something isn't working community

Comments

@zombiedk
Copy link

Describe the Bug

if you for a file have a source that uses puppet and you are using single quots it will conver it to comments

Expected Behavior

it should not make any changes to it

Steps to Reproduce

  file { '/etc/ssh/sshrc':
    mode   => 'a+rx',
    source => 'puppet:///modules/profile/auth/ssh/sshrc',
  }
puppet-lint --fix file.pp
FIXED: // comment found on line 57 (check: slash_comments)
FIXED: unquoted resource title on line 57 (check: unquoted_resource_title)
FIXED: double quoted string containing no variables on line 62 (check: double_quoted_strings)

  file { '/etc/ssh/sshrc':
    mode   => 'a+rx',
    source => ''puppet':#/modules/profile/auth/ssh/sshrc',
}

but if you are using dubble quots there is no proble

  file { '/etc/ssh/sshrc':
    mode   => 'a+rx',
    source => "puppet:///modules/profile/auth/ssh/sshrc",
  }

Environment

  • Version [3.3.0]
  • Platform [Ubuntu 22.10]
@zombiedk zombiedk added the bug Something isn't working label Mar 22, 2023
@chelnak
Copy link

chelnak commented Mar 23, 2023

Looks like this is a built-in plugin.

We will investigate and get back to you!

@chelnak chelnak assigned chelnak and unassigned chelnak Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community
Projects
None yet
Development

No branches or pull requests

3 participants