Implement puppet-lint-plugin helper metods

[bastelfreak]

Use Case

Hi!
multiple puppet-lint plugins carry the same methods to extract some data: https://github.com/voxpupuli/puppet-lint-optional_default-check/blob/master/lib/puppet-lint/plugins/check_optional_default.rb#L46-L140

they are currently copied over to new gems if they require those functions. I think they are really helpful and would be a good fit for puppet-lint itself. I do not have proper Ruby/puppet-lint knowledge to implement them myself here, so I'm raising this ticket.

Describe the Solution You Would Like

Implement the methods from the linked puppet-lint plugin in puppet-lint core.

Describe Alternatives You've Considered

copy them to new gems if required

Additional Context

nothing

[ekohl]

You should link to a specific commit so the line numbers can't change anymore. On the blob page (in your current link) there's a keyboard shortcut y to change the URL to:
https://github.com/voxpupuli/puppet-lint-optional_default-check/blob/ea35a85e51571794c0038293147d4e68974461d4/lib/puppet-lint/plugins/check_optional_default.rb#L46-L140

[ekohl]

As you can see, puppet-lint today only has a lexer. I'm not sure if you want to maintain a full parser in puppet-lint or if you can reuse something. Perhaps at that point you actually want the parser used in Puppet itself (which is racc) and operate on that. That would be much heavier though. Way more expensive and you'd tie to Puppet internals.

I think you actually want a parser and an abstract syntax tree (or concrete syntax tree). Then you can do more advanced checks. I also felt the desire for that.

[chelnak]

@ekohl @bastelfreak Is this still something that people would be interested in?

I'd be happy to take a look.. just probably need to understand it ask a bit more so we can make sure the DX is good.