Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report on the doc: URLs to Prim.Row module are unreachable #397

Open
matoruru opened this issue Aug 2, 2019 · 6 comments
Open

Report on the doc: URLs to Prim.Row module are unreachable #397

matoruru opened this issue Aug 2, 2019 · 6 comments

Comments

@matoruru
Copy link

matoruru commented Aug 2, 2019

Hello maintainer,

I found some unreachable URLs as the issue title.

For Example: in https://pursuit.purescript.org/packages/purescript-typelevel-prelude/5.0.0/docs/Type.Row, "Re-exports from Prim.Row" is an unreachable link. The destination is https://pursuit.purescript.org/packages/purescript-typelevel-prelude/5.0.0/docs/Prim.Row

@matoruru
Copy link
Author

matoruru commented Aug 2, 2019

I think it need to be updated.

@garyb
Copy link
Member

garyb commented Aug 2, 2019

I think this a bug in pursuit, the Prim modules are special, so the link should resolve to https://pursuit.purescript.org/builtins/docs/Prim.Row rather than treating it as a normal module.

Do you agree @hdgarrood? If so, let's move the issue over there.

@hdgarrood
Copy link
Collaborator

This is definitely a bug in either pursuit or the compiler, because this link is rendered by one of them (I don’t remember which). In any case it is definitely not the responsibility of the library author.

I think this bug might already have been fixed, and we might just need to update Pursuit to build against the latest compiler and deploy it.

@garyb
Copy link
Member

garyb commented Aug 2, 2019

Okidoke. I'll transfer this to the pursuit repo anyway then, and we can close it when we figure out what's responsible / whether it's fixed. 🙂

@garyb garyb transferred this issue from purescript/purescript-typelevel-prelude Aug 2, 2019
@garyb garyb changed the title Report on the doc: URLs to Row module are unreachable Report on the doc: URLs to Prim.Row module are unreachable Aug 2, 2019
@paulyoung
Copy link

@JordanMartinez
Copy link
Contributor

This bug still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants