-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can not publish when compiler version is not available #1062
Comments
@flip111 since you opened so many issues for various things, some of which are likely easy to fix, do you plan on contributing those fixes? |
I contributed as tester of the new spago next version |
I'll take that as a no. @f-f how much of the publish pipeline uses the locally-installed |
We necessarily have to use the local compiler to ensure that the package can indeed compile before submitting it to the registry (the registry pipeline will try to compile it, so we might as well fail locally instead of waiting for that). So I guess the answer is "we use it quite a lot":
The error in this report is coming up because the local purescript version was not yet supported by the registry pipeline. One can go around that by downgrading the local version, but I don't think that's an acceptable solution - if we have published a compiler then we ought to support it throughout our infrastructure. I think the proper fix for this would be to make sure that on every release of the compiler we'd also automatically update the registry to support the new release - this would entail automatically pushing patches like this one |
Ideally the PureScript compiler release process would include updating |
|
@thomashoneyman would it make sense if the compiler had its own Nix scaffolding so we wouldn't have to update an extra repo? (we'd still need to update the Registry CI) |
We need to support a range of compiler versions so pointing at the compiler repo is unsuitable, unfortunately. I also doubt the compiler team wants to support a Nix build (in purescript-overlay I'm just exposing the binary, not a full build). I'm certainly happy to move purescript-overlay to be owned by the core team, but I haven't done so simply because it includes tools like purs-tidy and purescript-optimizer which aren't core, but which almost every project should have access to. |
The core team and the compiler team have very much overlap, so I'd say that if the Registry - in its role of packaging infrastructure - relies on a Nix build to use the compiler, then it's fair to say that Nix build needs to be supported by someone in core. I see virtually no difference between "the compiler repo contains a bunch of Nix code" and "there's an external repo that is updated on release" - in both cases if it breaks then the release manager has to fix it. There is an advantage in having it in the repo, which is that we can version that code together with the rest, which is less bureaucratic. |
Before on the registry github https://github.com/purescript/registry/issues it was possible to specify a compiler version. I didn't see such a configuration available here https://github.com/purescript/spago#the-configuration-file
I get this error
How do i set the compiler version to
0.15.10
?The text was updated successfully, but these errors were encountered: