Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help for outfile #1172

Open
flip111 opened this issue Jan 18, 2024 · 3 comments
Open

Help for outfile #1172

flip111 opened this issue Jan 18, 2024 · 3 comments

Comments

@flip111
Copy link
Contributor

flip111 commented Jan 18, 2024

It's not clear from the description whether this flag takes a filename or a filepath

--outfile ARG Destination path for the bundle

I would suggested either the following

  1. --outfile FILENAME Filename for the bundle
  2. --outpath FILEPATH Directory and filename for the bundle
@f-f
Copy link
Member

f-f commented Jan 18, 2024

How is it not clear? It says "path".

@flip111
Copy link
Contributor Author

flip111 commented Jan 18, 2024

It's not clear because of file in outfile and ARG which is generic name for an argument. An example where it's done well is with --output DIR The output directory for compiled files

@f-f
Copy link
Member

f-f commented Jan 18, 2024

I am not sure we customise that:

spago/bin/src/Flags.purs

Lines 67 to 73 in 6d8e02f

outfile :: Parser (Maybe String)
outfile =
OT.optional
$ O.strOption
( O.long "outfile"
<> O.help "Destination path for the bundle"
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants